Add dockerfiles for juno #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This repo is used for Travis and recently Blake started working on running Travis builds through Houston. It sounded like he had already made good progress so I'm gonna hold off on reviewing/merging this unless his solution isn't ready in time. Since updating the Travis would require a lot of per-project PRs anyway. |
|
Closing this one now as it will probably be superseded by #6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obviously the stable image currently doesn't build as those repository don't exist yet. But the other two do.
I have added devel container is per issue #2. Currently using the daily repository. It installs just some base packages used by most travis builds. Additional dependencies can be added at runtime through an environment variable
dependencies.Most of the dockerfile contents are identical. I did think about setting up a base image but that ended up being more complicated then needed and create bigger images.